Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor graph and configuration into separate packages #432

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

pleshakov
Copy link
Contributor

  • Move graph-related types and functions to state/graph package. Those are further split into Gateway resource-related file like httproute.go
  • Move configuration-related types and functions to state/dataplane package
  • Add package docs for both packages.

Note: the dataplane.Configuration now depends on the graph.BackendGroup. As a result, internal/nginx/config generator-types depend on the graph package. This will be addressed separately in a different PR pending the review of this PR.

- Move graph-related types and functions to state/graph package. Those
are further split into Gateway resource-related file like httproute.go
- Move configuration-related types and functions to state/dataplane
package
- Add package docs for both packages.
@pleshakov pleshakov requested a review from a team as a code owner February 15, 2023 21:38
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 15, 2023
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new organization looks good! Thanks for doing this. I just have a couple small comments and questions

internal/events/handler.go Show resolved Hide resolved
internal/helpers/sort.go Outdated Show resolved Hide resolved
internal/state/change_processor.go Show resolved Hide resolved
internal/state/dataplane/configuration.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pleshakov pleshakov merged commit 68d1f6e into main Feb 22, 2023
@pleshakov pleshakov deleted the chore/refactor-state-pkg branch February 22, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants