-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect SnippetsFilter information #2677
Collect SnippetsFilter information #2677
Conversation
Will add manual testing soon, though review of naming and logic can happen now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
- Coverage 88.89% 88.80% -0.10%
==========================================
Files 110 109 -1
Lines 8556 8386 -170
Branches 50 0 -50
==========================================
- Hits 7606 7447 -159
+ Misses 892 881 -11
Partials 58 58 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if the directive came first in the string, then the context. This goes for all variable/function names too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Verified data on xcdf side, will now merge. |
1404777
to
ab3bcb7
Compare
Proposed changes
Collect SnippetsFilters count, the directive-context of each snippet, and the total count of each unique directive-context.
Problem: I want to know if SnippetsFilters are being used, and what are the most popular directives being used.
Solution: Collect SnippetsFilter count, the directive-context of each snippet, and the total count of each unique directive-context.
Testing: Manual testing and unit tests.
Output with the example SnippetsFilters.yaml deployed. (removed other telemetry points for easier reading)
Output with no SnippetsFilters deployed.
Closes #2373
Closes #2375
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.