Use go test as unit test runner #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
approved these changes
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
=======================================
Coverage ? 88.43%
=======================================
Files ? 104
Lines ? 7880
Branches ? 0
=======================================
Hits ? 6969
Misses ? 854
Partials ? 57 ☔ View full report in Codecov by Sentry. |
bjee19
approved these changes
Sep 26, 2024
|
Hmm, code coverage dropped significantly. Looks like it's considering fake files now? |
lucacome
requested changes
Sep 26, 2024
should we try to exclude them? |
I'm trying to figure out how to do that. Doesn't seem very straightforward. Not sure how it worked with ginkgo... |
|
I might just be able to configure codecov to ignore certain paths. |
sjberman
force-pushed
the
tests/unit-test-runner
branch
from
284ff25
to
0500c7b
Compare
Problem: Switching to using ginkgo as the test runner caused some issues with verbose output and difficulty finding test failures. This could also be exacerbated by the fact that we mix standard go test style with ginkgo framework tests. Solution: For now, switch back to using go test as the runner, since the output is cleaner and easier to find errors.
sjberman
force-pushed
the
tests/unit-test-runner
branch
from
0500c7b
to
a38de0f
Compare
lucacome
approved these changes
Sep 26, 2024
salonichf5
pushed a commit
that referenced
this pull request
Oct 8, 2024
Problem: Switching to using ginkgo as the test runner caused some issues with verbose output and difficulty finding test failures. This could also be exacerbated by the fact that we mix standard go test style with ginkgo framework tests. Solution: For now, switch back to using go test as the runner, since the output is cleaner and easier to find errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Switching to using ginkgo as the test runner caused some issues with verbose output and difficulty finding test failures. This could also be exacerbated by the fact that we mix standard go test style with ginkgo framework tests.
Solution: For now, switch back to using go test as the runner, since the output is cleaner and easier to find errors.
Closes #2584
Future work: #2612
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.