Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unchecked type assertions #2580

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

Fixes the remaining unchecked type assertions

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 18, 2024 21:54
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Sep 18, 2024
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (dc3a925) to head (ee2070b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mode/static/manager.go 0.00% 8 Missing ⚠️
internal/framework/status/updater.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   95.19%   89.20%   -6.00%     
==========================================
  Files           1      100      +99     
  Lines         229     7642    +7413     
  Branches       50       50              
==========================================
+ Hits          218     6817    +6599     
- Misses         11      768     +757     
- Partials        0       57      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for the missing unit tests

internal/framework/status/updater.go Outdated Show resolved Hide resolved
internal/mode/static/manager.go Show resolved Hide resolved
@lucacome lucacome assigned lucacome and unassigned bjee19 Sep 24, 2024
@lucacome lucacome enabled auto-merge (squash) September 24, 2024 18:24
@lucacome lucacome merged commit 79636f4 into nginxinc:main Sep 24, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants