Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import shadowing and unchecked type assertions in test #2574

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Removes shadowing of imports and adds type assertion checks in tests. A separate PR will fix type assertions in code.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 17, 2024 22:43
@lucacome lucacome assigned lucacome and unassigned mpstefan Sep 17, 2024
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (a2aa4d3) to head (79fc769).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/framework/helpers/helpers.go 25.00% 2 Missing and 1 partial ⚠️
internal/mode/static/manager.go 0.00% 3 Missing ⚠️
internal/mode/static/handler.go 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2574   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files         100      100           
  Lines        7633     7633           
  Branches       50       50           
=======================================
  Hits         6816     6816           
  Misses        761      761           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/framework/status/updater_test.go Outdated Show resolved Hide resolved
internal/mode/static/state/dataplane/configuration.go Outdated Show resolved Hide resolved
internal/mode/static/state/graph/gateway_listener.go Outdated Show resolved Hide resolved
tests/framework/resourcemanager.go Show resolved Hide resolved
@lucacome lucacome force-pushed the chore/shadowing-type-assertion branch from c5177bf to 07e4a5c Compare September 18, 2024 17:57
@lucacome lucacome requested review from kate-osborn and a team September 18, 2024 17:59
@lucacome lucacome enabled auto-merge (squash) September 18, 2024 20:01
@lucacome lucacome merged commit 9971881 into nginxinc:main Sep 18, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants