Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLA GitHub Action #2510

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Use CLA GitHub Action #2510

merged 3 commits into from
Sep 5, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Sep 5, 2024

Proposed changes

Use GitHub Action to sign the CLA

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 5, 2024 01:37
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (026cc97) to head (76af75c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         100      100           
  Lines        7539     7539           
  Branches       50       50           
=======================================
  Hits         6726     6726           
  Misses        756      756           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 5, 2024
.github/workflows/f5-cla.yml Show resolved Hide resolved
.github/workflows/f5-cla.yml Outdated Show resolved Hide resolved
.github/workflows/f5-cla.yml Outdated Show resolved Hide resolved
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alessfg for visibility

@lucacome lucacome merged commit bb14dc1 into nginxinc:main Sep 5, 2024
37 checks passed
@lucacome lucacome deleted the chore/cla branch September 5, 2024 23:23
# Remote repository storing CLA signatures.
remote-organization-name: "f5"
remote-repository-name: "f5-cla-data"
path-to-signatures: "signatures/beta/signatures.json"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path will need to be updated to remove the beta at some stage :)

@lucacome lucacome assigned lucacome and unassigned mpstefan Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants