Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NginxGateway functional test #2486

Merged
merged 21 commits into from
Sep 4, 2024

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 29, 2024

Proposed changes

Add a functional test for the NginxGateway resource.

Problem: We would like a functional test for the NginxGateway resource to ensure its working correctly.

Solution: Add the functional test.

Testing: Test works.

Closes #1808

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

None

@bjee19 bjee19 requested a review from a team as a code owner August 29, 2024 22:17
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (2544818) to head (da027f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         100      100           
  Lines        7539     7539           
  Branches       50       50           
=======================================
  Hits         6726     6726           
  Misses        756      756           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjee19
Copy link
Contributor Author

bjee19 commented Aug 29, 2024

Should I try to start on #2449 and add some better logging? But I'm not too sure what could be a good start / example.

tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/framework/ngf.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/manifests/nginxgateway/nginx-gateway.yaml Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
tests/suite/nginxgateway_test.go Outdated Show resolved Hide resolved
@bjee19 bjee19 force-pushed the tests/add-functional-nginx-gateway-test branch from c19ad60 to da027f8 Compare September 4, 2024 23:18
@bjee19 bjee19 merged commit d308a00 into nginxinc:main Sep 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Functional Test for NginxGateway
5 participants