-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NginxGateway functional test #2486
Merged
bjee19
merged 21 commits into
nginxinc:main
from
bjee19:tests/add-functional-nginx-gateway-test
Sep 4, 2024
Merged
Add NginxGateway functional test #2486
bjee19
merged 21 commits into
nginxinc:main
from
bjee19:tests/add-functional-nginx-gateway-test
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjee19
commented
Aug 29, 2024
bjee19
commented
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 100 100
Lines 7539 7539
Branches 50 50
=======================================
Hits 6726 6726
Misses 756 756
Partials 57 57 ☔ View full report in Codecov by Sentry. |
bjee19
commented
Aug 29, 2024
Should I try to start on #2449 and add some better logging? But I'm not too sure what could be a good start / example. |
lucacome
reviewed
Aug 29, 2024
sjberman
reviewed
Aug 30, 2024
bjee19
commented
Sep 2, 2024
kate-osborn
requested changes
Sep 3, 2024
sjberman
approved these changes
Sep 3, 2024
kate-osborn
requested changes
Sep 3, 2024
sjberman
approved these changes
Sep 4, 2024
kate-osborn
requested changes
Sep 4, 2024
kate-osborn
approved these changes
Sep 4, 2024
bjee19
force-pushed
the
tests/add-functional-nginx-gateway-test
branch
from
September 4, 2024 23:18
c19ad60
to
da027f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a functional test for the NginxGateway resource.
Problem: We would like a functional test for the NginxGateway resource to ensure its working correctly.
Solution: Add the functional test.
Testing: Test works.
Closes #1808
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.