Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for NFR tests to 5h #2380

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: Performance tests alone take 2.5 hours.

Solution: Increase the timeout to 5 hours

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: Performance tests alone take 2.5 hours.

Solution: Increase the timeout to 5 hours
@lucacome lucacome requested a review from a team as a code owner August 12, 2024 23:05
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e9b0a92) to head (2b564b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2380   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         100      100           
  Lines        7513     7513           
  Branches       50       50           
=======================================
  Hits         6676     6676           
  Misses        781      781           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) August 12, 2024 23:20
@lucacome lucacome merged commit dcc83dc into nginxinc:main Aug 12, 2024
37 checks passed
@lucacome lucacome deleted the chore/increase-timeout-nfr-tests branch August 12, 2024 23:32
@sjberman
Copy link
Contributor

Performance tests as in just the reconfig tests take 2.5 hours?

@lucacome
Copy link
Member Author

it appears so @sjberman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants