Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server zone metrics #2360

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Aug 9, 2024

Problem: server_zone metrics were not being emitted for NGINX Plus users

Solution: Add these metrics to the server blocks when running NGINX Plus

Testing: Verified that server_zone metrics show up in Prometheus

Closes #2220

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Added server_zone metrics for NGINX Plus users.

Problem: server_zone metrics were not being emitted for NGINX Plus users

Solution: Add these metrics to the server blocks when running NGINX Plus
@sjberman sjberman requested a review from a team as a code owner August 9, 2024 19:03
@github-actions github-actions bot added the enhancement New feature or request label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (6289c6e) to head (17eef72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2360   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         100      100           
  Lines        7509     7513    +4     
  Branches       50       50           
=======================================
+ Hits         6672     6676    +4     
  Misses        781      781           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) August 12, 2024 13:30
@sjberman sjberman merged commit 0ced21f into nginxinc:main Aug 12, 2024
37 checks passed
@sjberman sjberman deleted the feat/server-zone-metrics branch August 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NGINX Plus: Server Zone Metrics are not Emitted
4 participants