Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for chart version and add command output #2332

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 6, 2024

Proposed changes

Problem: There's not a way to specify the version of the Chart and to see the command used to install.

Solution: Add a parameter to specify the version of the Chart. When installing from a registry if no version is specified the latest tag will be installed. For now only the edge version will set the edge tag. Also output the command used to install.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 6, 2024 02:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 6, 2024
@lucacome lucacome self-assigned this Aug 6, 2024
@lucacome lucacome changed the title Add options for chart version and output command Add options for chart version and add command output Aug 6, 2024
tests/scripts/sync-files-to-vm.sh Show resolved Hide resolved
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Show resolved Hide resolved
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (6295850) to head (b1c98fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2332   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          96       96           
  Lines        6847     6847           
  Branches       50       50           
=======================================
  Hits         6010     6010           
  Misses        780      780           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Problem: There's not a way to specify the version of the Chart and to
see the command used to install.

Solution: Add a parameter to specify the version of the Chart. When
installing from a registry if no version is specified the latest tag
will be installed. For now only the edge version will set the edge tag.
Also output the command used to install.
@lucacome lucacome enabled auto-merge (squash) August 7, 2024 16:50
@lucacome lucacome disabled auto-merge August 7, 2024 16:51
@lucacome lucacome enabled auto-merge (squash) August 7, 2024 16:51
@lucacome lucacome merged commit 5f8509a into nginxinc:main Aug 7, 2024
37 checks passed
@lucacome lucacome deleted the chore/tests branch August 7, 2024 17:11
@lucacome lucacome added tests Pull requests that update tests and removed chore Pull requests for routine tasks labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants