-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for chart version and add command output #2332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
changed the title
Add options for chart version and output command
Add options for chart version and add command output
Aug 6, 2024
sjberman
reviewed
Aug 6, 2024
lucacome
commented
Aug 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 96 96
Lines 6847 6847
Branches 50 50
=======================================
Hits 6010 6010
Misses 780 780
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Problem: There's not a way to specify the version of the Chart and to see the command used to install. Solution: Add a parameter to specify the version of the Chart. When installing from a registry if no version is specified the latest tag will be installed. For now only the edge version will set the edge tag. Also output the command used to install.
salonichf5
reviewed
Aug 7, 2024
sjberman
reviewed
Aug 7, 2024
sjberman
approved these changes
Aug 7, 2024
kate-osborn
approved these changes
Aug 7, 2024
lucacome
added
tests
Pull requests that update tests
and removed
chore
Pull requests for routine tasks
labels
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: There's not a way to specify the version of the Chart and to see the command used to install.
Solution: Add a parameter to specify the version of the Chart. When installing from a registry if no version is specified the latest tag will be installed. For now only the edge version will set the edge tag. Also output the command used to install.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.