Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TODO route condition with an Accepted/False condition #2228

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: When a route references a Gateway that is ignored, NGF adds the TODO condition: The condition for this has not been implemented yet: Gateway is ignored. This does not communicate to the user that the route is not accepted because the Gateway it references is ignored.

Solution: Change this condition to be Accepted/False/GatewayIgnored.

Testing: Verified that the condition is added to routes that reference an ignored Gateway.

Closes #2015

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@kate-osborn kate-osborn requested review from a team as code owners July 11, 2024 18:21
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (efea992) to head (99ecaaa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2228   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          96       96           
  Lines        6715     6715           
  Branches       50       50           
=======================================
  Hits         5884     5884           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn merged commit a9dbdca into nginxinc:main Jul 11, 2024
37 checks passed
@kate-osborn kate-osborn mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Routes that reference an ignored Gateway are marked as Accepted
3 participants