Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP Response Headers document link #2210

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jul 9, 2024

Proposed changes

This commit fixes the HTTP response headers link: the GitHub example attempted to link to the markdown file on the production website instead of the repository file or the live URL.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


This commit fixes the HTTP response headers link: the GitHub example
attempted to link to the markdown file on the production website instead
of the repository file or the live URL.
@ADubhlaoich ADubhlaoich self-assigned this Jul 9, 2024
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner July 9, 2024 13:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 9, 2024
@ADubhlaoich
Copy link
Contributor Author

pre-commit.ci autofix

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) July 9, 2024 13:57
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (5fdcdde) to head (f79d4a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2210   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          96       96           
  Lines        6715     6715           
  Branches       50       50           
=======================================
  Hits         5884     5884           
  Misses        774      774           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich merged commit d0bb08b into nginxinc:main Jul 12, 2024
37 checks passed
@ADubhlaoich ADubhlaoich deleted the fix-headers-link branch July 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants