Move Advanced NGINX Extensions proposal to Implementable #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Advanced NGINX Extensions proposal nginxinc#2035 is in Provisional state - only problem statement is defined. Solution: - Add the implementation details to the proposal. - Move the enhancement proposal to Implementable Notes: - The goal of Allowing users to customize supported NGINX configuration was moved to a Non-Goal to keep the size of the proposal manageable. - This enhancement proposal can be further split into two - one for SnippetsPolicy and one for SnippetsTemplates CLOSES - nginxinc#815
github-actions
bot
added
documentation
|
@pleshakov is this PR ready for review? |
kate-osborn
requested changes
Jul 8, 2024
sjberman
reviewed
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 96 96
Lines 6793 6793
Branches 50 50
=======================================
Hits 5962 5962
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
reviewed
Jul 12, 2024
mpstefan
approved these changes
Jul 12, 2024
kate-osborn
requested changes
Jul 12, 2024
|
My only other comment would be to change the status to Implementable. |
sjberman
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Solution:
Notes:
CLOSES - #815
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.