-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom annotations into GatewayClass and NginxGateway manifests #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # charts/nginx-gateway-fabric/README.md
github-actions
bot
added
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
labels
May 20, 2024
salonichf5
requested changes
May 20, 2024
sjberman
reviewed
May 23, 2024
sjberman
approved these changes
May 29, 2024
kate-osborn
approved these changes
May 29, 2024
salonichf5
approved these changes
Jun 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
+ Coverage 87.61% 87.66% +0.04%
==========================================
Files 96 93 -3
Lines 6694 6557 -137
Branches 50 50
==========================================
- Hits 5865 5748 -117
+ Misses 773 753 -20
Partials 56 56 ☔ View full report in Codecov by Sentry. |
lucacome
changed the title
Add custom annotations into GatewayClass and NginxGateway manifests (reopened)
Add custom annotations into GatewayClass and NginxGateway manifests
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Based on previous accidentally closed PR-1899
Add custom annotations for GatewayClass and NginxGateway objects.
It can be useful in different cases
Problem: For deploying our service we use ArgoCD. For this, we have a Helm Chart that contains multiple resources that are using CRDs, that are not managed by this helm chart. When trying to sync this application, it fails if at least one CRD is not installed in the cluster. This is expected.
Solution: To work around this problem, we want to use SkipDryRunOnMissingResource option as annotation for GatewayClass and NginxGateway objects from the nginx-gateway-fabric chart
Testing: Helm template works fine.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.