Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for nginx_reloads_milliseconds metrics #1986

Merged
merged 1 commit into from
May 17, 2024

Conversation

salonichf5
Copy link
Contributor

Proposed changes

Problem: Documentation for nginx_reloads_milliseconds metrics is missing in NGF docs.

Solution: Add documentation for nginx_reloads_milliseconds.

Testing: TODO

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #1861

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@salonichf5 salonichf5 requested review from a team as code owners May 16, 2024 22:04
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels May 16, 2024
@sjberman sjberman removed the bug Something isn't working label May 17, 2024
@salonichf5 salonichf5 merged commit 59c8f50 into nginxinc:main May 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Documentation for nginx_reloads_milliseconds metrics is missing
5 participants