Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add basic grpc example #1905

Merged
merged 3 commits into from
May 2, 2024

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Apr 30, 2024

Proposed changes

Problem: We need an easy way to configure and test GRPCRoute examples

Solution: Add a basic example with a sample hello world application and configurations for the 3 primary gRPC routing methods

Testing: Ran through the example locally

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested review from a team as code owners April 30, 2024 11:32
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Apr 30, 2024
@ciarams87 ciarams87 mentioned this pull request Apr 30, 2024
6 tasks
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Apr 30, 2024
@ciarams87 ciarams87 force-pushed the docs/add-basic-grpc-example branch from c416ec4 to a5e0434 Compare May 2, 2024 09:58
@ciarams87 ciarams87 merged commit 8505f8b into nginxinc:main May 2, 2024
40 checks passed
@ciarams87 ciarams87 deleted the docs/add-basic-grpc-example branch May 2, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants