Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig #1849

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add EditorConfig #1849

merged 3 commits into from
Apr 18, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 18, 2024

Proposed changes

Problem: Every editor has different defaults.

Solution: Use EditorConfig to define coding styles

Closes #1739

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: Every editor has different defaults.

Solution: Use EditorConfig to define coding styles
@lucacome lucacome requested a review from a team as a code owner April 18, 2024 01:08
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (69522ee) to head (9114f09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1849   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files          83       83           
  Lines        5540     5540           
  Branches       52       52           
=======================================
  Hits         4776     4776           
  Misses        715      715           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) April 18, 2024 16:47
@lucacome lucacome merged commit f762373 into nginxinc:main Apr 18, 2024
38 checks passed
@lucacome lucacome deleted the chore/editorconfig branch April 19, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add EditorConfig
3 participants