Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservabilityPolicy Enhancement Proposal #1795

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Apr 1, 2024

Problem: We want a design for Observability-related configuration settings, such as tracing, to be applied at the HTTPRoute level.

Solution: Add enhancement proposal introducing ObservabilityPolicy.

Closes #1662

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@sjberman sjberman requested review from a team as code owners April 1, 2024 21:49
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 1, 2024
@sjberman sjberman added enhancement New feature or request enhancement-proposal Enhancement Proposal issue and removed enhancement New feature or request labels Apr 2, 2024
docs/proposals/observability.md Outdated Show resolved Hide resolved
docs/proposals/observability.md Show resolved Hide resolved
docs/proposals/observability.md Outdated Show resolved Hide resolved
docs/proposals/observability.md Show resolved Hide resolved
docs/proposals/observability.md Outdated Show resolved Hide resolved
@sjberman sjberman force-pushed the docs/proposals/observability-policy branch from 5f19a33 to d68ca07 Compare April 3, 2024 15:54
docs/proposals/observability.md Show resolved Hide resolved
docs/proposals/observability.md Show resolved Hide resolved
docs/proposals/observability.md Outdated Show resolved Hide resolved
Problem: We want a design for Observability-related configuration settings, such as tracing, to be applied at the HTTPRoute level.

Solution: Add enhancement proposal introducing `ObservabilityPolicy`.
@sjberman sjberman force-pushed the docs/proposals/observability-policy branch from b855c1d to 14457ff Compare April 5, 2024 22:08
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (2277050) to head (14457ff).

❗ Current head 14457ff differs from pull request most recent head 05e8c7a. Consider uploading reports for the commit 05e8c7a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
- Coverage   86.20%   86.18%   -0.03%     
==========================================
  Files          83       87       +4     
  Lines        5540     5522      -18     
  Branches       52       52              
==========================================
- Hits         4776     4759      -17     
- Misses        715      717       +2     
+ Partials       49       46       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) April 17, 2024 13:58
@sjberman sjberman merged commit e79f137 into nginxinc:main Apr 17, 2024
38 checks passed
@sjberman sjberman deleted the docs/proposals/observability-policy branch April 17, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement-proposal Enhancement Proposal issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Design Observability Policy for OpenTelemetry Traces
3 participants