Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark old data plane proposal as Replaced #1756

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

sjberman
Copy link
Contributor

The old data plane CRD proposal has been replaced with a newer and better proposal for adding native NGINX configuration to the API.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

The old data plane CRD proposal has been replaced with a newer and better proposal for adding native NGINX configuration to the API.
@sjberman sjberman requested review from a team as code owners March 22, 2024 15:30
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Mar 22, 2024
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@sjberman sjberman enabled auto-merge (squash) March 22, 2024 17:26
@sjberman sjberman merged commit 0765072 into nginxinc:main Mar 22, 2024
40 checks passed
@sjberman sjberman deleted the chore/replace-proposal branch March 22, 2024 17:39
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
The old data plane CRD proposal has been replaced with a newer and better proposal for adding native NGINX configuration to the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants