NFR: Add convenience script and update workflow token #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ciarams87
force-pushed
the
chore/update-nfr-tests
branch
from
9dce745
to
74d20d2
Compare
ciarams87
changed the title
sjberman
reviewed
Mar 6, 2024
sjberman
reviewed
Mar 6, 2024
sjberman
reviewed
Mar 6, 2024
ciarams87
force-pushed
the
chore/update-nfr-tests
branch
from
25f6b22
to
b164ef3
Compare
sjberman
approved these changes
Mar 6, 2024
kate-osborn
approved these changes
Mar 6, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
* Add convenience script and update workflow token --------- Co-authored-by: Saylor Berman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The NFR workflow is failing because of insufficient token access. Additionally, users of the NFR test framework may want to access the GKE clusters locally, but currently the local IP is not being added to the cluster.
Solution: Update the workflow token, and add convenience script to add the local IP to the master authorised networks of the cluster.
Testing: Local testing
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.