Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov #1626

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add Codecov #1626

merged 2 commits into from
Feb 28, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 28, 2024

Proposed changes

Problem: We don't have a history of our code coverage and we want to see how it changes over time and with every PR. We also want to have a badge that shows the overall coverage.

Solution: Use Codecov to upload coverage and get diffs in every PR that changes code. Also add a badge in the README to show the coverage.

Closes #1514

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: We don't have a history of our code coverage and we want to see
how it changes over time and with every PR. We also want to have a badge
that shows the overall coverage.

Solution: Use Codecov to upload coverage and get diffs in every PR that
changes code. Also add a badge in the README to show the coverage.
@lucacome lucacome self-assigned this Feb 28, 2024
@lucacome lucacome requested a review from a team as a code owner February 28, 2024 21:03
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Feb 28, 2024
@lucacome lucacome merged commit 8c7a0e2 into nginxinc:main Feb 28, 2024
36 checks passed
@lucacome lucacome deleted the chore/add-codecov branch February 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Show code coverage for NGF PRs and Project
3 participants