v1.1.0 Longevity test #1359
Merged
v1.1.0 Longevity test #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nginx-gateway-fabric canceled.
|
github-actions
bot
added
documentation
kate-osborn
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I do think it's worth it to re-run the longevity tests so that we have metrics to compare 1.3 to, but I don't think it should block the release. There are no new errors, memory leaks, or CPU spikes that require investigation. Reloads are well-covered by other NFR tests I'm not sure how much insight we are getting from the nginx stub-status metrics.
pleshakov
approved these changes
Dec 11, 2023
ciarams87
force-pushed
the
tests/v1.1.0-longevity
branch
from
3b5ce34
to
72f5f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We want to run our longevity test for every release and capture the findings.
Solution: Run the longevity test and commit the results.
Please focus on (optional): There was an error in the setup of the prometheus logging, so the NGINX metrics were not correctly exported.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.