Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 Longevity test #1359

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: We want to run our longevity test for every release and capture the findings.

Solution: Run the longevity test and commit the results.

Please focus on (optional): There was an error in the setup of the prometheus logging, so the NGINX metrics were not correctly exported.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner December 11, 2023 15:26
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 72f5f09
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/657837470f108d00083a260a

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Dec 11, 2023
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it's worth it to re-run the longevity tests so that we have metrics to compare 1.3 to, but I don't think it should block the release. There are no new errors, memory leaks, or CPU spikes that require investigation. Reloads are well-covered by other NFR tests I'm not sure how much insight we are getting from the nginx stub-status metrics.

@ciarams87 ciarams87 merged commit 15717d3 into nginxinc:main Dec 12, 2023
27 checks passed
@ciarams87 ciarams87 deleted the tests/v1.1.0-longevity branch December 12, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants