Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero-downtime-upgrades results for 1.1.0 #1353

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Add zero-downtime-upgrades results for 1.1.0 #1353

merged 4 commits into from
Dec 8, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Dec 7, 2023

Added results and fixed up the instructions to use helm.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman
Add zero-downtime-upgrades results for 1.1.0
316c093 
Added results and fixed up the instructions to use helm.
@sjberman sjberman requested a review from a team as a code owner December 7, 2023 20:54
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 9bf97e1
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65734c716527b400081e51fb

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Dec 7, 2023
pleshakov
pleshakov approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/zero-downtime-upgrades/zero-downtime-upgrades.md Outdated Show resolved Hide resolved
@sjberman sjberman merged commit 56016e9 into nginxinc:main Dec 8, 2023
27 checks passed
@sjberman sjberman deleted the tests/zero-downtime-upgrades branch December 8, 2023 17:38
@sjberman sjberman mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjberman @pleshakov @ciarams87