Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netlify note to release process doc #1350

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Add netlify note to release process doc #1350

merged 6 commits into from
Dec 8, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Dec 7, 2023

Ensure that we are updating the Netlify production branch when releasing.

@sjberman
Add netlify note to release process doc
862cddb 
Ensure that we are updating the Netlify production branch when releasing.
@sjberman sjberman requested review from a team as code owners December 7, 2023 15:52
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 619185f
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65735f7c92f344000871d3b9

@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Dec 7, 2023
ADubhlaoich
ADubhlaoich approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though there's still some discussion going on that should be addressed.

Always enjoyable to see a process like this written down.

@sjberman sjberman merged commit 3d38822 into nginxinc:main Dec 8, 2023
27 checks passed
@sjberman sjberman deleted the chore/release-process-netlify branch December 8, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjberman @pleshakov @ADubhlaoich