Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest stable version of Go #1348

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Dec 7, 2023

Proposed changes

Problem: Since Go changed the versioning in go.mod to specify a patch release in 1.21, we don't use the latest go version when building the binary anymore.
Before with 1.20 in go.mod we would use the latest version of 1.20.x, but now since we specify 1.21.3 in go.mod we use that fixed version and not 1.21.4 for example, and future updates.

Solution: Update the pipeline to always use the latest stable version of Go in the pipeline.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: Since Go changed the versioning in go.mod to specify a patch
release in 1.21, we don't use the latest go version when building the
binary anymore.
Before with 1.20 in go.mod we would use the latest version of 1.20.x,
but now since we specify 1.21.3 in go.mod we use that fixed version
and not 1.21.4 for example, and future updates.

Solution: Update the pipeline to always use the latest stable version of
Go in the pipeline.
@lucacome lucacome self-assigned this Dec 7, 2023
@lucacome lucacome requested a review from a team as a code owner December 7, 2023 02:35
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit ec8851c
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/657208890d483a0008261acd

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 7, 2023
@lucacome lucacome merged commit 0f44f43 into nginxinc:main Dec 7, 2023
27 checks passed
@lucacome lucacome deleted the chore/go-version branch December 7, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants