Use latest stable version of Go #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Since Go changed the versioning in go.mod to specify a patch release in 1.21, we don't use the latest go version when building the binary anymore. Before with 1.20 in go.mod we would use the latest version of 1.20.x, but now since we specify 1.21.3 in go.mod we use that fixed version and not 1.21.4 for example, and future updates. Solution: Update the pipeline to always use the latest stable version of Go in the pipeline.
✅ Deploy Preview for nginx-gateway-fabric canceled.
|
sjberman
approved these changes
Dec 7, 2023
bjee19
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Since Go changed the versioning in go.mod to specify a patch release in 1.21, we don't use the latest go version when building the binary anymore.
Before with 1.20 in go.mod we would use the latest version of 1.20.x, but now since we specify 1.21.3 in go.mod we use that fixed version and not 1.21.4 for example, and future updates.
Solution: Update the pipeline to always use the latest stable version of Go in the pipeline.
Checklist
Before creating a PR, run through this checklist and mark each as complete.