Fail run conformance test make target on test failure #1177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The conformance tests jobs are not being marked as failed in the pipeline even when there are failed tests. This is because the last command in the pod and the Make target relate to the conformance profile report and not the tests themselves, so the exit code is always 0 as long as the job completes.
Solution: Fetch the test result from the conformance profile yaml and exit with 2 if there's a failure result
Testing: Tested the conformance tests locally and verified that the make target fails when there's a failure in the conformance tests, and doesn't fail when there isn't
Closes #1176
Checklist
Before creating a PR, run through this checklist and mark each as complete.