-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataplane performance test #1140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 13, 2023
kate-osborn
requested changes
Oct 13, 2023
ciarams87
force-pushed
the
tests/dp-performance
branch
from
October 16, 2023 09:05
0288524
to
54094b1
Compare
pleshakov
reviewed
Oct 16, 2023
ciarams87
force-pushed
the
tests/dp-performance
branch
from
October 16, 2023 15:14
2927d4f
to
e457d0c
Compare
sjberman
reviewed
Oct 16, 2023
kate-osborn
approved these changes
Oct 16, 2023
bjee19
approved these changes
Oct 16, 2023
pleshakov
reviewed
Oct 16, 2023
ciarams87
force-pushed
the
tests/dp-performance
branch
from
October 17, 2023 08:46
461d03a
to
0ad9ac9
Compare
pleshakov
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sjberman
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a developer of NGF, I want to know the average latency of requests being proxied through NGINX using a variety of routing rules, so that I can know if different routing rules provide different results, and so that I can know if any future work has an impact on data plane performance.
Solution: Create HTTPRoutes to configure different matches all pointing to the same application, use wrk to send requests to the different routes, and capture the results.
Please focus on (optional): I only have a single backend application to ensure that wasn't an influential factor in the performance measurement.
Closes #953
Checklist
Before creating a PR, run through this checklist and mark each as complete.