Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fieldalignment error #1137

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix fieldalignment error #1137

merged 1 commit into from
Oct 12, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: Lint check failed on merge to main: https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/6499802831/job/17654089998

Solution: Fix fieldalignment error

Additional Context

Filed a ticket to make sure we are catching all linting errors before merging: #1136

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner October 12, 2023 19:26
@github-actions github-actions bot added the bug Something isn't working label Oct 12, 2023
bjee19
bjee19 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter doesn't work 😞

@kate-osborn kate-osborn merged commit a41e9e4 into nginxinc:main Oct 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjee19 bjee19 bjee19 approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kate-osborn @sjberman @bjee19