Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Production Endpoint for Product Telemetry #1563

Closed
Tracked by #793
ja20222 opened this issue Feb 12, 2024 · 2 comments
Closed
Tracked by #793

Enable Production Endpoint for Product Telemetry #1563

ja20222 opened this issue Feb 12, 2024 · 2 comments
Assignees
@pleshakov
Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days tests Pull requests that update tests
Milestone
v1.2.0

Comments

@ja20222
Copy link

ja20222 commented Feb 12, 2024 •
edited by mpstefan
Loading

As an NGF maintainer
I want to enable and test the production telemetry endpoint
So that I can collect and verify that data is exported properly

Acceptance

  • Production endpoint for product telemetry is enabled for exporting data
  • A manual verification is done to ensure that data is received as intended
@ja20222 ja20222 added the area/telemetry Issues related to collected telemetry data label Feb 12, 2024
@sjberman sjberman mentioned this issue Feb 12, 2024
Closed
@mpstefan mpstefan added the tests Pull requests that update tests label Feb 13, 2024
@mpstefan mpstefan added this to the v1.2.0 milestone Feb 13, 2024
@pleshakov pleshakov added the blocked Blocked by other issue label Feb 26, 2024
@pleshakov
Copy link
Contributor

blocked by #1377

@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Feb 26, 2024
@pleshakov pleshakov self-assigned this Mar 13, 2024
@pleshakov pleshakov moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Mar 13, 2024
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 13, 2024
@pleshakov
Enable Production Endpoint for Product Telemetry
67cc619 
Problem:
Start sending product telemetry to the product F5 telemetry service.

Solution:
- Use the production telemetry endpoint in production NGF image, built
  using:
  - goreleaser
  - make commands from building the images doc
- Introduce new targets in the Makefile for building prod images.

Developer instructions for building NGF image remain unchanged, and
such image will not send any telemetry, but will report it in the logs
at the debug level.

Testing:
- Confirmed production NGF image built using make command sends
  telemetry.
- Confirmed developer NGF image build using make command doesn't send
  any telemetry but reports it in the logs.

CLOSES - nginxinc#1563
@pleshakov pleshakov mentioned this issue Mar 13, 2024
Closed
9 tasks
@pleshakov pleshakov removed the blocked Blocked by other issue label Mar 14, 2024
@pleshakov pleshakov mentioned this issue Mar 15, 2024
Merged
6 tasks
@pleshakov pleshakov moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric Mar 15, 2024
sjberman pushed a commit that referenced this issue Mar 15, 2024
@pleshakov
Enable Production Endpoint for Product Telemetry (#1699)
b6cb677 
Problem:
Start sending product telemetry to the product F5 telemetry service.

Solution:
- Use the production telemetry endpoint in production NGF image, built
  using:
  - goreleaser
  - make commands from building the images doc
- Introduce new targets in the Makefile for building prod images.

Developer instructions for building NGF image remain unchanged, and
such image will not send any telemetry, but will report it in the logs
at the debug level.

Testing:
- Confirmed production NGF image built using make command sends
  telemetry.
- Confirmed developer NGF image build using make command doesn't send
  any telemetry but reports it in the logs.

CLOSES - #1563
@sjberman
Copy link
Contributor

Closed by #1699

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Mar 15, 2024
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this issue Apr 3, 2024
@pleshakov @amimimor
Enable Production Endpoint for Product Telemetry (nginxinc#1699)
5620626 
Problem:
Start sending product telemetry to the product F5 telemetry service.

Solution:
- Use the production telemetry endpoint in production NGF image, built
  using:
  - goreleaser
  - make commands from building the images doc
- Introduce new targets in the Makefile for building prod images.

Developer instructions for building NGF image remain unchanged, and
such image will not send any telemetry, but will report it in the logs
at the debug level.

Testing:
- Confirmed production NGF image built using make command sends
  telemetry.
- Confirmed developer NGF image build using make command doesn't send
  any telemetry but reports it in the logs.

CLOSES - nginxinc#1563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
area/telemetry Issues related to collected telemetry data refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.2.0
Development

No branches or pull requests
4 participants
@pleshakov @mpstefan @sjberman @ja20222