Add more feedback from reviews

nginxinc · Mar 13, 2024 · c970b6b · c970b6b
1 parent 4374166
commit c970b6b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/mode/static/telemetry/collector.go b/internal/mode/static/telemetry/collector.go
@@ -292,10 +292,11 @@ func collectClusterInformation(ctx context.Context, k8sClient client.Reader) (cl
 	}
 	node := nodes.Items[0]
 
-	clusterInfo.Version = "unknown"
 	kubeletVersion := node.Status.NodeInfo.KubeletVersion
 	version, err := k8sversion.ParseGeneric(kubeletVersion)
-	if err == nil {
+	if err != nil {
+		clusterInfo.Version = "unknown"
+	} else {
 		clusterInfo.Version = version.String()
 	}
 

diff --git a/internal/mode/static/telemetry/platform.go b/internal/mode/static/telemetry/platform.go
@@ -69,7 +69,7 @@ func getPlatform(node v1.Node, namespaces v1.NamespaceList) string {
 
 func openShiftExtractor(state k8sState) string {
 	// openshift platform won't show up in node's ProviderID
-	if value, ok := state.node.Labels[openshiftIdentifier]; ok && value != "" {
+	if state.node.Labels[openshiftIdentifier] != "" {
 		return platformOpenShift
 	}