Skip to content

Commit

Permalink
More suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
sjberman committed Aug 7, 2023
1 parent 096a020 commit aa8dcbd
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions docs/proposals/control-plane-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ or `edit` the configuration.
Proposed configuration CRD example:

```yaml
apiVersion: nginx.gateway.k8s.io/v1alpha1
apiVersion: gateway.nginx.org/v1alpha1
kind: NGINXControlConfig
metadata:
name: nkg-config
Expand All @@ -55,9 +55,13 @@ status:
then an error is logged and event created, and default values are used.
- If user deletes resource, NKG logs an error and creates an event. NKG will revert to default values.
This resource won't be referenced in the `parametersRef` of the GatewayClass, reserving that option for a data
plane CRD. The control plane may end up supporting multiple GatewayClasses, so linking the control CRD to a
GatewayClass wouldn't make sense. Referencing the CRD via a CLI argument ensures we only support one instance of
the CRD per control plane.

For discussion with team:

- API group name
- kind name
- default resource name

Expand Down

0 comments on commit aa8dcbd

Please sign in to comment.