Skip to content

Commit

Permalink
Add a FIXME about refactoring BackendGroups
Browse files Browse the repository at this point in the history
  • Loading branch information
pleshakov committed Mar 14, 2023
1 parent c9f5834 commit 3b5a532
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions internal/state/graph/httproute.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ type Route struct {
}

// GetAllBackendGroups returns BackendGroups for all rules with valid matches and filters in the Route.
//
// FIXME(pleshakov) Improve the name once https://github.com/nginxinc/nginx-kubernetes-gateway/issues/468 is
// implemented. The current name doesn't reflect the filtering of rules inside the loops.
// See also the discussion below for more context:
// https://github.com/nginxinc/nginx-kubernetes-gateway/pull/455#discussion_r1136277589
func (r *Route) GetAllBackendGroups() []BackendGroup {
count := 0

Expand Down

0 comments on commit 3b5a532

Please sign in to comment.