Update validateBackendRef invalid group error conditions (#800)

* Reverse order for validateBackendRef error conditions * Instead of reversing order, change condition reason for invalid group
nginxinc · Jun 28, 2023 · 1f8a416 · 1f8a416
1 parent b322ce1
commit 1f8a416
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/state/graph/backend_refs.go b/internal/state/graph/backend_refs.go
@@ -171,7 +171,7 @@ func validateBackendRef(
 
 	if ref.Group != nil && !(*ref.Group == "core" || *ref.Group == "") {
 		valErr := field.NotSupported(path.Child("group"), *ref.Group, []string{"core", ""})
-		return false, conditions.NewRouteBackendRefUnsupportedValue(valErr.Error())
+		return false, conditions.NewRouteBackendRefInvalidKind(valErr.Error())
 	}
 
 	if ref.Kind != nil && *ref.Kind != "Service" {

diff --git a/internal/state/graph/backend_refs_test.go b/internal/state/graph/backend_refs_test.go
@@ -123,7 +123,7 @@ func TestValidateBackendRef(t *testing.T) {
 				return backend
 			}),
 			expectedValid: false,
-			expectedCondition: conditions.NewRouteBackendRefUnsupportedValue(
+			expectedCondition: conditions.NewRouteBackendRefInvalidKind(
 				`test.group: Unsupported value: "invalid": supported values: "core", ""`,
 			),
 		},