Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status to VirtualServer and VirtualServerRoute #973

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Add status to VirtualServer and VirtualServerRoute #973

merged 1 commit into from
Jun 4, 2020

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented May 29, 2020

Proposed changes

This PR adds a status field to VirtualServer and VirtualServerRoute resources.

pleshakov
pleshakov approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox lgtm!

however, could you make to fix those small comments before merging? Thanks!

pkg/apis/configuration/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/configuration/v1/types.go Show resolved Hide resolved
LorcanMcVeigh
LorcanMcVeigh approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@Rulox Rulox force-pushed the vs-vsr-status branch 2 times, most recently from 867303a to 8602143 Compare June 2, 2020 11:34
@Rulox Rulox merged commit 07eb78a into master Jun 4, 2020
@Rulox Rulox deleted the vs-vsr-status branch June 4, 2020 16:40
@Rulox Rulox mentioned this pull request Jun 4, 2020
Merged
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rulox @pleshakov @LorcanMcVeigh