Updated replacement logic in release scripts #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
suggested changes
May 15, 2020
There was a problem hiding this comment.
@LorcanMcVeigh please see my comments.
I noticed the description of this PR (Proposed changes) is different from #952 Is it intentional?
6 tasks
|
@LorcanMcVeigh |
is that not the latest image on dockerhub? |
LorcanMcVeigh
force-pushed
the
update-scripts
branch
from
45089b9
to
4a5f6f1
Compare
LorcanMcVeigh
force-pushed
the
update-scripts
branch
from
fda96ca
to
38f3b45
Compare
Rulox
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update release helper scripts:
Update the changelog template - added ubi image.
Fix version replacement logic.
updated docs-web/technical-specifications.md
Checklist
Before creating a PR, run through this checklist and mark each as complete.