Add pod PriorityClass support #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
reviewed
Jan 8, 2020
There was a problem hiding this comment.
Thanks a lot for the PR @gsnegovskiy !
Looks good. Just a few comments/suggestions.
- We like to document all options in the values.yaml. I understand there is no reasonable default for this though.
So I suggest adding something like the following false-y value as a default so nothing is rendered in the template.
## The PriorityClass of the ingress controller pods.
priorityClassName:This would be similar to how controller.defaultTLS.secret is listed.
- I think it may make more sense to nest under controller.pod but I don't feel so strongly about this. What do ye think @Rulox @pleshakov ?
pleshakov
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
@gsnegovskiy thanks for the PR!
Lgmt pending @Dean-Coakley suggestion about the values.yaml file.
I think it may make more sense to nest under controller.pod but I don't feel so strongly about this. What do ye think @Rulox @pleshakov ?
I think it is fine as is and consistent with the other similar parameters like controller.tolerations
added 2 commits
January 10, 2020 14:40
…egovskiy/kubernetes-ingress into add-priority-class-to-helm-templates
|
@Dean-Coakley @pleshakov Thank's for the review! Hopefully I've added documentation in a right place inside values.yaml Anything else I can do to fit standards ? |
Dean-Coakley
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PriorityClass for pods is a stable feature since Kubernetes 1.14
It will be useful to have it available to configure priorities for ingress controller.