Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Ingress labeled metrics on start #736

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Init Ingress labeled metrics on start #736

merged 1 commit into from
Oct 24, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Oct 23, 2019

Proposed changes

Labeled Ingress Resources metrics are shown (and set to 0) even if there are no ingress resources in the cluster when the IC runs for the first time.

@Rulox Rulox self-assigned this Oct 23, 2019
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 71f79b9 into master Oct 24, 2019
@pleshakov pleshakov deleted the init-metrics branch December 17, 2019 11:20
@pleshakov pleshakov added the bug An issue reporting a potential bug label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants