Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service subselector support in vs/vsr #712

Merged
merged 7 commits into from
Oct 4, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • When using VS/VSRs, Subselector support allows you to configure NGINX to route requests to different groups of pods of the same service based on kubernetes labels.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Sep 27, 2019
@Dean-Coakley Dean-Coakley self-assigned this Sep 27, 2019
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please see a few suggestions.

internal/k8s/controller.go Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller_test.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley good job! please see a suggestion related to the unit tests.

internal/configs/virtualserver.go Show resolved Hide resolved
@Dean-Coakley Dean-Coakley merged commit 898cca0 into master Oct 4, 2019
@Dean-Coakley Dean-Coakley deleted the support-service-subselector branch October 4, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants