Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning events in VS/VSR #707

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Emit warning events in VS/VSR #707

merged 1 commit into from
Sep 30, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Sep 26, 2019

Proposed changes

To give more insights to the end user that have no access to the IC logs, now we report warnings for all VS and VSR if they are added or updated but with some errors.

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Sep 26, 2019
@Rulox Rulox self-assigned this Sep 26, 2019
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please implement the small suggestions before merging

internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
internal/k8s/controller_test.go Outdated Show resolved Hide resolved
@Rulox Rulox merged commit 198967e into master Sep 30, 2019
@Rulox Rulox deleted the vs-vsr-events branch September 30, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants