Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support queue in upstreams for plus in VS/VSR #701

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

bvighnesha
Copy link

@bvighnesha bvighnesha commented Sep 25, 2019

Proposed changes

NGINX Plus supports specifying a queue for an upstream. If an upstream server cannot be selected immediately while processing a request, the request will be placed into the queue. See http://nginx.org/en/docs/http/ngx_http_upstream_module.html#queue

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions in docs/strings for consistency with the rest of the code, let me know what you think.

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@bvighnesha bvighnesha force-pushed the feature/support_upstream_queue_in_plus branch from 1e9a1b3 to 16f1bde Compare September 25, 2019 12:01
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bvighnesha bvighnesha merged commit 03baf19 into master Sep 26, 2019
@Rulox Rulox deleted the feature/support_upstream_queue_in_plus branch September 27, 2019 11:00
@pleshakov pleshakov changed the title Add support queue in upstreams for plus Add support queue in upstreams for plus in VS/VSR Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants