Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor EndpointSlice controller #6323

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Sep 2, 2024

Proposed changes

This change moves the Endpoint Slice controller code to it's own file to help reduce the complexity of controller.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner September 2, 2024 09:47
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 53.01%. Comparing base (a079805) to head (67c4a9f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/endpoint_slice.go 0.00% 85 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6323      +/-   ##
==========================================
- Coverage   53.05%   53.01%   -0.04%     
==========================================
  Files          77       79       +2     
  Lines       15921    15921              
==========================================
- Hits         8447     8441       -6     
- Misses       7069     7073       +4     
- Partials      405      407       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 1a8870e into main Sep 2, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the controller-endpoint-slice-refactor branch September 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants