Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NAP WAF v5 example link, minor style issues #6294

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

One of the links in the NGINX App Protect V5 configuration document is broken.

This commit fixes the link, and also makes some other changes so the document is more closely in line with contemporary standards.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ADubhlaoich ADubhlaoich self-assigned this Aug 27, 2024
@ADubhlaoich ADubhlaoich requested review from a team as code owners August 27, 2024 08:37
@ADubhlaoich ADubhlaoich added the needs cherry pick Cherry pick this PR into a release branch label Aug 27, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 27, 2024
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6294/

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) September 3, 2024 15:25
@ADubhlaoich ADubhlaoich merged commit ccd88fd into main Sep 3, 2024
30 checks passed
@ADubhlaoich ADubhlaoich deleted the fix-app-v5-example branch September 3, 2024 15:26
nginx-bot pushed a commit that referenced this pull request Sep 3, 2024
One of the links in the NGINX App Protect V5 configuration 
document is broken. This commit fixes the link, and also 
makes some other changes so the document is more 
closely in line with contemporary standards.
ADubhlaoich added a commit that referenced this pull request Sep 3, 2024
Fix NAP WAF v5 example link, minor style issues (#6294)

One of the links in the NGINX App Protect V5 configuration 
document is broken. This commit fixes the link, and also 
makes some other changes so the document is more 
closely in line with contemporary standards.

Co-authored-by: Alan Dooley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants