Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor App Protect WAF controller #6263

Merged
merged 5 commits into from
Aug 28, 2024
Merged

refactor App Protect WAF controller #6263

merged 5 commits into from
Aug 28, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 20, 2024

Proposed changes

This change moves the App Protect WAF controller code to it's own file to help reduce the complexity of controller.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner August 20, 2024 15:59
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 15.17028% with 274 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (2d0d193) to head (9b8751e).
Report is 4 commits behind head on main.

Files Patch % Lines
internal/k8s/appprotect_waf.go 15.17% 272 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6263      +/-   ##
==========================================
- Coverage   52.98%   52.95%   -0.03%     
==========================================
  Files          76       77       +1     
  Lines       15900    15900              
==========================================
- Hits         8424     8420       -4     
- Misses       7071     7073       +2     
- Partials      405      407       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 4769963 into main Aug 28, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the controller-waf-refactor branch August 28, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants