Fix manifest CRD documentation #6197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restructures the custom resource section of the Installation with Manifests documentation to remove redundant instructions and more clearly delineate the NAP-specific instructions from the core definitions. Using includes, a potential furthur improvement for the future would be to fully compartmentalise any NAP WAF or DOS documentation into their "Integration" subsections, removing them from the critical user path.
github-actions
bot
added
the
documentation
✅ Deploy Preview will be available once build job completes!
|
Jcahilltorre
approved these changes
Aug 14, 2024
pdabelf5
approved these changes
Aug 14, 2024
ADubhlaoich
added a commit
that referenced
this pull request
Aug 15, 2024
This commit restructures the custom resource section of the Installation with Manifests documentation to remove redundant instructions and more clearly delineate the NAP-specific instructions from the core definitions. Using includes, a potential furthur improvement for the future would be to fully compartmentalise any NAP WAF or DOS documentation into their "Integration" subsections, removing them from the critical user path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit restructures the custom resource section of the Installation with Manifests documentation to remove redundant instructions and more clearly delineate the NAP-specific instructions from the core definitions.
Using includes, a potential furthur improvement for the future would be to fully compartmentalise any NAP WAF or DOS documentation into their "Integration" subsections, removing them from the critical user path.
Checklist
Before creating a PR, run through this checklist and mark each as complete.