Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for template executor and helpers #6182

Merged
merged 23 commits into from
Aug 16, 2024
Merged

Add missing tests for template executor and helpers #6182

merged 23 commits into from
Aug 16, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 13, 2024

Proposed changes

This PR adds missing tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 13, 2024 11:48
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 13, 2024
@jjngx jjngx added the tests Pull requests that update tests label Aug 13, 2024
@github-actions github-actions bot removed the tests Pull requests that update tests label Aug 13, 2024
@jjngx jjngx changed the title Add tests for template executor Add tests for template executor and helpers Aug 13, 2024
@jjngx jjngx added the tests Pull requests that update tests label Aug 13, 2024
@github-actions github-actions bot removed the tests Pull requests that update tests label Aug 13, 2024
@jjngx jjngx changed the title Add tests for template executor and helpers Add missing tests for template executor and helpers Aug 13, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.88%. Comparing base (491e68e) to head (4ec9337).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6182      +/-   ##
==========================================
+ Coverage   45.58%   45.88%   +0.29%     
==========================================
  Files         142      142              
  Lines       18961    18961              
==========================================
+ Hits         8644     8700      +56     
+ Misses       9868     9816      -52     
+ Partials      449      445       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit cb2e2b4 into main Aug 16, 2024
79 checks passed
@jjngx jjngx deleted the test/coverage branch August 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants