Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeouts support to vs/vsr #612

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Add timeouts support to vs/vsr #612

merged 4 commits into from
Jul 4, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Support configuring timeouts in upstreams of VirtualServer/VirtualServerRoute

Add support for the following when using to vs/vsrs:

  • connect-timeout
  • read-timeout
  • send-timeout

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 3, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jul 3, 2019
@Dean-Coakley Dean-Coakley requested review from peterkellydev and removed request for FranzBlancaflor July 3, 2019 12:44
Rulox
Rulox suggested changes Jul 4, 2019
View reviewed changes
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
pleshakov
pleshakov suggested changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

Make sure to test when using the rules and splits routes.

Makefile Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
internal/configs/version1/config.go Outdated Show resolved Hide resolved
internal/configs/ingress_test.go Outdated Show resolved Hide resolved
internal/configs/version2/config.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
internal/configs/ingress.go Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dean-Coakley Dean-Coakley merged commit 722c673 into master Jul 4, 2019
@Dean-Coakley Dean-Coakley deleted the features/vs-vsr-upstream-timeouts branch July 4, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox