Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily remove fips images from release registry #6080

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 29, 2024

Proposed changes

Prevent publishing FIPS images to the internal release registry. This will prevent https://github.com/nginxinc/kubernetes-ingress/actions/runs/10127928032/job/28035941844 from failing.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 29, 2024 09:59
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 29, 2024
@pdabelf5 pdabelf5 merged commit 1cf6941 into main Jul 29, 2024
81 checks passed
@pdabelf5 pdabelf5 deleted the fips-internal-gcr branch July 29, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants