replace promlog with go-kit #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
added
dependencies
vepatel
approved these changes
Jul 24, 2024
…83d002b4e81c37e51556cda0f8d
pdabelf5
approved these changes
Jul 24, 2024
pdabelf5
deleted the
cherry-pick-release-3.6-9cb9b3e95a33d83d002b4e81c37e51556cda0f8d
branch
pdabelf5
changed the title
pdabelf5
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
recent
prometheus-commonversion cause issues with go linter & tests, replace thepromloglogging library withgo-kit, a similar logger with the same interface.Checklist
Before creating a PR, run through this checklist and mark each as complete.