Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update keycloak version in OIDC example #6049

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jul 23, 2024

Proposed changes

Update keycloak version to the latest in the OIDC example. Modify URLs in the OIDC example to reflect Keycloak API change.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 23, 2024
@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch 2 times, most recently from 15ba054 to dfbf0de Compare July 23, 2024 13:00
@haywoodsh haywoodsh changed the title update keycloak version in examples update keycloak version in OIDC example Jul 23, 2024
@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from dfbf0de to 35df921 Compare July 23, 2024 13:01
@haywoodsh haywoodsh marked this pull request as ready for review July 23, 2024 13:02
@haywoodsh haywoodsh requested a review from a team as a code owner July 23, 2024 13:02
@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from 35df921 to 788efda Compare July 23, 2024 13:04
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth highlighting to the user the minimum keycloak version these commands work for.

@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from ff710d0 to 962e7cb Compare July 24, 2024 11:03
@haywoodsh
Copy link
Contributor Author

Might be worth highlighting to the user the minimum keycloak version these commands work for.

Tested and added the minimum Keycloak version 19.0.2. Earlier versions are incompatible with either the auth endpoints, Keycloak set up commands, or the Keycloak deployment manifests in this PR.

@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from 962e7cb to 2a89fc1 Compare July 24, 2024 11:08
@haywoodsh haywoodsh requested a review from a team July 24, 2024 11:53
@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from 2a89fc1 to d6406d6 Compare July 24, 2024 11:54
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]>

Signed-off-by: Haywood Shannon <[email protected]>
@haywoodsh haywoodsh force-pushed the chore/update-example-keycloak-version branch from d6406d6 to e11298d Compare July 24, 2024 15:04
@haywoodsh haywoodsh enabled auto-merge (squash) July 24, 2024 15:05
@haywoodsh haywoodsh merged commit e316fdd into main Jul 24, 2024
52 checks passed
@haywoodsh haywoodsh deleted the chore/update-example-keycloak-version branch July 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants