Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate NAP WAF v5 #5698

Merged
merged 41 commits into from
Jun 12, 2024
Merged

Integrate NAP WAF v5 #5698

merged 41 commits into from
Jun 12, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jun 6, 2024 •
edited
Loading

Proposed changes

This PR makes the following changes:

  1. Adds 4 new build stages, and make commands, to build the NGINX Ingress Controller with AppProtect WAF v5
  2. Adds a new Helm values, controller.appprotect.v5. Setting this option to true will two additional containers that are required for WAF v5 images. See the AppProtect v5 Kubernetes Admin Guide for more details.

Resolves #5646

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code docker Pull requests that update Docker code chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels Jun 6, 2024
@shaun-nx shaun-nx linked an issue Jun 6, 2024 that may be closed by this pull request
Integrate NAP WAF v5 #5646
Closed
@shaun-nx shaun-nx removed the chore Pull requests for routine tasks label Jun 6, 2024
@shaun-nx shaun-nx changed the title Integrate AppProtect WAF v5 Integrate NAP WAF v5 Jun 6, 2024
@shaun-nx shaun-nx marked this pull request as ready for review June 6, 2024 09:20
@shaun-nx shaun-nx requested a review from a team as a code owner June 6, 2024 09:20
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 6, 2024
@shaun-nx shaun-nx requested a review from vepatel June 7, 2024 12:05
shaun-nx
shaun-nx commented Jun 7, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
vepatel
vepatel reviewed Jun 7, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Jun 7, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 10, 2024
@oseoin
Copy link
Contributor

oseoin commented Jun 11, 2024

Confirmed Security Monitoring with v5
image

@oseoin oseoin merged commit adcdd3d into main Jun 12, 2024
54 of 81 checks passed
@oseoin oseoin deleted the feat/waf-v5 branch June 12, 2024 16:22
pdabelf5 pushed a commit that referenced this pull request Jun 17, 2024
@shaun-nx @pdabelf5
Integrate NAP WAF v5 (#5698)
f6717e1
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@shaun-nx @ssrahul96
Integrate NAP WAF v5 (nginxinc#5698)
0dea2e5
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@oseoin oseoin oseoin left review comments

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements github_actions Pull requests that update Github_actions code go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate NAP WAF v5
5 participants
@shaun-nx @oseoin @vepatel @jjngx @pdabelf5